Re: [PATCH] ucb1400_ts depends SND_AC97_BUS

[Takashi Iwai <tiwai@xxxxxxx>]

At Fri, 05 Sep 2008 01:09:48 -0400 (EDT),
Nicolas Pitre wrote:
> 
> On Thu, 4 Sep 2008, Randy Dunlap wrote:
> 
> > On Fri, 05 Sep 2008 00:37:17 -0400 (EDT) Nicolas Pitre wrote:
> > 
> > > On Thu, 4 Sep 2008, Randy Dunlap wrote:
> > > 
> > > > On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote:
> > > > 
> > > > > On Sat, 9 Dec 2006, Randy Dunlap wrote:
> > > > > 
> > > > > > On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
> > > > > > 
> > > > > > > Please consider what SND_CONFIG_AC97_BUS corresponds to.  It is 
> > > > > > > sound/pci/ac97/ac97_bus.c and if you look into this file you'll see that 
> > > > > > > it is perfectly buildable even if sound is entirely configured out, just 
> > > > > > > like some lib code would be.
> > > > > > 
> > > > > > OK.  Should it (CONFIG_SND_AC97_BUS -> sound/pci/ac97/ac97_bus.c)
> > > > > > be buildable when sound is disabled?
> > > > > 
> > > > > Yes.
> > > > > 
> > > > > > If so, where should it be moved to (since afaik, make won't even
> > > > > > descend into sound/ if SOUND=n; I don't see that changing
> > > > > > any time soon).
> > > > > 
> > > > > What about this patch?
> > > > 
> > > > Can we get this patch or some patch into the input tree for linux-next?
> > > 
> > > This patch is commit e1036502e5263851259d147771226161e5ccc85a and 
> > > appeared in mainline almost 2 years ago.
> > 
> > Ack.  Sorry about that.  Wrong ucb thread.
> > 
> > ucb1400_core still has build errors in linux-next
> > since it uses ac97_bus_type even when CONFIG_SOUND=n.
> 
> Both sound (AC97) and UCB1400 should be able to select CONFIG_AC97_BUS 
> independently from each other.
> 
> And in linux/sound/Makefile one can find this note:
> 
> 	# This one must be compilable even if sound is configured out
> 	obj-$(CONFIG_AC97_BUS) += ac97_bus.o
> 
> This was fixed 2 years ago.  Who broke it this time?

Oh, it must be me.

Could you check the patch below?


thanks,

Takashi

diff --git a/sound/Kconfig b/sound/Kconfig
index a37bee0..164a53a 100644
--- a/sound/Kconfig
+++ b/sound/Kconfig
@@ -91,6 +91,9 @@ endif # SOUND_PRIME
 
 endif # !M68K
 
+endif # SOUND
+
+# AC97_BUS is used from both sound and ucb1400
 config AC97_BUS
 	tristate
 	help
@@ -99,4 +102,3 @@ config AC97_BUS
 	  sound although they're sharing the AC97 bus. Concerned drivers
 	  should "select" this.
 
-endif # SOUND
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/