Re: [PATCH v2] Staging: rtl8192e: Fix sparse warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 06, 2014 at 01:43:38PM -0500, Joel Pelaez Jorge wrote:
> Fix a sparse warning, non static symbol is no declared as such.
> And fix a conflict with static function declared extern to include
> rtl_wx.h header.
> 
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning:
> symbol 'r8192_wx_handlers_def' was not declared. Should it be static?
> 
> Signed-off-by: Joel Pelaez Jorge <joelpelaez@xxxxxxxxx>
> ---
>   drivers/staging/rtl8192e/rtl8192e/rtl_wx.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c 
> b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> index 498995d..f17584d 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> @@ -19,6 +19,7 @@
> 
>   #include <linux/string.h>
>   #include "rtl_core.h"
> +#include "rtl_wx.h"

Why is this needed?

> 
>   #define RATE_COUNT 12
>   static u32 rtl8192_rates[] = {
> @@ -1293,7 +1294,7 @@ static iw_handler r8192_private_handler[] = {
>   	(iw_handler)r8192_wx_get_PromiscuousMode,
>   };
> 
> -static struct iw_statistics *r8192_get_wireless_stats(struct net_device 
> *dev)
> +struct iw_statistics *r8192_get_wireless_stats(struct net_device *dev)

Why make this global?  This doesn't have anything to do with the warning
you are working on as described above.

totally confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/




[Index of Archives]

  Powered by Linux

[Older Kernel Discussion]     [Yosemite National Park Forum]     [Large Format Photos]     [Gimp]     [Yosemite Photos]     [Stuff]     [Index of Other Archives]