Re: [PATCH 01/31] Disable const sections for PA-RISC

[Sam Ravnborg <sam@xxxxxxxxxxxx>]

On Sat, Aug 18, 2012 at 10:29:52AM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> 
> The PA-RISC tool chain seems to have some problem with correct read/write
> attributes on sections. This causes problems when the const sections
> are fixed up for other architecture to only contain truly read-only
> data.
> 
> Disable const sections for PA-RISC
> 
> This can cause a bit of noise with modpost.
> 
> Cc: James.Bottomley@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> ---
>  arch/parisc/Kconfig  |    4 ++++
>  include/linux/init.h |   27 +++++++++++++++++++--------
>  2 files changed, 23 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
> index 3ff21b5..fbfeec9 100644
> --- a/arch/parisc/Kconfig
> +++ b/arch/parisc/Kconfig
> @@ -243,6 +243,10 @@ config NODES_SHIFT
>  	default "3"
>  	depends on NEED_MULTIPLE_NODES
>  
> +config BROKEN_RODATA
> +	bool
> +	default y

Could you please change this so we have a commonly defined HAVE_BROKEN_RODATA
symbol. Then arch's that have broken RO data can select this symbol.
If we experience tomorrow that sparc have the same issue then with
this patch sparc has to create a local definition of this symbol.

This allows you to add some comments of the usage of this symbol
in a common place too.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/