Re: [PATCH v2 03/22] ARM: use late patch framework for phys-virt patching
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
On 08/11/12 23:03, Nicolas Pitre wrote:
On Fri, 10 Aug 2012, Cyril Chemparathy wrote:This patch replaces the original physical offset patching implementation with one that uses the newly added patching framework. In the process, we now unconditionally initialize the __pv_phys_offset and __pv_offset globals in the head.S code.This last sentence is now wrong.
-extern unsigned long __pv_phys_offset; -#define PHYS_OFFSET __pv_phys_offset
+#define PHYS_OFFSET __virt_to_phys(PAGE_OFFSET)What was wrong with the former PHYS_OFFSET = __pv_phys_offset ? If you really want to have it optimized at run time, you could simply use your new stub to patch a mov instruction instead of going through __virt_to_phys which uses and add on top of a constant.
The intent was to optimize out the load(s) on references to PHYS_OFFSET, but is it worth it? If so, we could go with a patched mov (or two) with the necessary endian fixups. If not, we could revert to __pv_phys_offset loads as before.
s = find_mod_section(hdr, sechdrs, ".runtime.patch.table"); if (s) runtime_patch((void *)s->sh_addr, s->sh_size);I missed this in the previous patch, but could you fail the module loading by returning an error if runtime_patch() fails? That would take care of not accepting modules that might have been compiled with future runtime patching extensions that are not yet supported in an earlier kernel.
You also should remove the MODULE_ARCH_VERMAGIC_P2V definitions now that the corresponding code is no longer there.
Hmm..."rt-patch" needs to be in vermagic to prevent modules built against the new code from being loaded on older kernels that used the traditional patch code.
"p2v" needs to be in there as well, because it should be possible to build without PATCH_PHYS_VIRT, but with RUNTIME_PATCH as and when there are other users for this.
Thanks -- Cyril. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[Other Archives] [Linux Kernel Newbies] [Linux Driver Development] [Linux Kbuild] [Fedora Kernel] [Linux Kernel Testers] [Linux SH] [Linux Omap] [Linux Tape] [Linux Input] [Linux Kernel Janitors] [Linux Kernel Packagers] [Linux Doc] [Linux Man Pages] [Linux API] [Linux Memory Management] [Linux Modules] [Linux Standards] [Kernel Announce] [Netdev] [Git] [Linux PCI] Linux CAN Development [Linux I2C] [Linux RDMA] [Linux NUMA] [Netfilter] [Netfilter Devel] [SELinux] [Bugtraq] [FIO] [Linux Perf Users] [Linux Serial] [Linux PPP] [Linux ISDN] [Linux Next] [Kernel Stable Commits] [Linux Tip Commits] [Kernel MM Commits] [Linux Security Module] [AutoFS] [Filesystem Development] [Ext3 Filesystem] [Linux bcache] [Ext4 Filesystem] [Linux BTRFS] [Linux CEPH Filesystem] [Linux XFS] [XFS] [Linux NFS] [Linux CIFS] [Ecryptfs] [Linux NILFS] [Linux Cachefs] [Reiser FS] [Initramfs] [Linux FB Devel] [Linux OpenGL] [DRI Devel] [Fastboot] [Linux RT Users] [Linux RT Stable] [eCos] [Corosync] [Linux Clusters] [LVS Devel] [Hot Plug] [Linux Virtualization] [KVM] [KVM PPC] [KVM ia64] [Linux Containers] [Linux Hexagon] [Linux Cgroups] [Util Linux] [Wireless] [Linux Bluetooth] [Bluez Devel] [Ethernet Bridging] [Embedded Linux] [Barebox] [Linux MMC] [Linux IIO] [Sparse] [Smatch] [Linux Arch] [x86 Platform Driver] [Linux ACPI] [Linux IBM ACPI] [LM Sensors] [CPU Freq] [Linux Power Management] [Linmodems] [Linux DCCP] [Linux SCTP] [ALSA Devel] [Linux USB] [Linux PA RISC] [Linux Samsung SOC] [MIPS Linux] [IBM S/390 Linux] [ARM Linux] [ARM Kernel] [ARM MSM] [Tegra Devel] [Sparc Linux] [Linux Security] [Linux Sound] [Linux Media] [Video 4 Linux] [Linux IRDA Users] [Linux for the blind] [Linux RAID] [Linux ATA RAID] [Device Mapper] [Linux SCSI] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Linux IDE] [Linux SMP] [Linux AXP] [Linux Alpha] [Linux M68K] [Linux ia64] [Linux 8086] [Linux x86_64] [Linux Config] [Linux Apps] [Linux MSDOS] [Linux X.25] [Linux Crypto] [DM Crypt] [Linux Trace Users] [Linux Btrace] [Linux Watchdog] [Utrace Devel] [Linux C Programming] [Linux Assembly] [Dash] [DWARVES] [Hail Devel] [Linux Kernel Debugger] [Linux gcc] [Gcc Help] [X.Org] [Wine]
[Older Kernel Discussion] [Yosemite National Park Forum] [Large Format Photos] [Gimp] [Yosemite Photos] [Stuff]