[3.5.1] tg3 waitqueue hang on hotplug remove...

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Hi Matt, Michael,

On my Macbook Retina with 3.5.1, I see the tg3 external adapter (via
Thunderbolt) get logically disconnected after a while despite
remaining connected (Thunderbolt issues).

The problem is though, that the pciehp_wq workqueue fails to complete
flushing from the call to pcie_cleanup_slot (inlined in
pciehp_release_ctrl) [1]; looks like tg3_tx or so is missing a
finish_wait(), no?


--- [1]

pcieport 0000:00:01.0: irq 42 for MSI/MSI-X
pcieport 0000:00:01.1: irq 43 for MSI/MSI-X
pcieport 0000:00:01.2: irq 44 for MSI/MSI-X
pcieport 0000:05:00.0: irq 45 for MSI/MSI-X
pcieport 0000:06:00.0: irq 46 for MSI/MSI-X
pcieport 0000:06:03.0: irq 47 for MSI/MSI-X
pcieport 0000:06:04.0: irq 48 for MSI/MSI-X
pcieport 0000:06:05.0: irq 49 for MSI/MSI-X
pcieport 0000:06:06.0: irq 50 for MSI/MSI-X
pcieport 0000:08:00.0: irq 51 for MSI/MSI-X
pcieport 0000:09:00.0: irq 52 for MSI/MSI-X
pci_hotplug: PCI Hot Plug PCI Core version: 0.5
pciehp 0000:06:00.0:pcie24: HPC vendor_id 8086 device_id 1547 ss_vid
2222 ss_did 1111
pciehp 0000:06:00.0:pcie24: service driver pciehp loaded
pciehp 0000:06:03.0:pcie24: HPC vendor_id 8086 device_id 1547 ss_vid
2222 ss_did 1111
pciehp 0000:06:03.0:pcie24: service driver pciehp loaded
pciehp 0000:06:04.0:pcie24: HPC vendor_id 8086 device_id 1547 ss_vid
2222 ss_did 1111
pciehp 0000:06:04.0:pcie24: service driver pciehp loaded
pciehp 0000:06:05.0:pcie24: HPC vendor_id 8086 device_id 1547 ss_vid
2222 ss_did 1111
pciehp 0000:06:05.0:pcie24: service driver pciehp loaded
pciehp 0000:06:06.0:pcie24: HPC vendor_id 8086 device_id 1547 ss_vid
2222 ss_did 1111
pciehp 0000:06:06.0:pcie24: service driver pciehp loaded
pciehp 0000:09:00.0:pcie24: HPC vendor_id 8086 device_id 1549 ss_vid 0 ss_did 0
pciehp 0000:09:00.0:pcie24: service driver pciehp loaded
pciehp: PCI Express Hot Plug Controller Driver version: 0.4
tg3 0000:0a:00.0: eth0: Tigon3 [partno(BCM957762) rev 57766000] (PCI
Express) MAC address 40:6c:8f:36:1a:67
tg3 0000:0a:00.0: eth0: attached PHY is 57765 (10/100/1000Base-T
Ethernet) (WireSpeed[1], EEE[0])
tg3 0000:0a:00.0: eth0: RXcsums[1] LinkChgREG[0] MIirq[0] ASF[0] TSOcap[1]
tg3 0000:0a:00.0: eth0: dma_rwctrl[00000001] dma_mask[64-bit]
pciehp 0000:06:03.0:pcie24: Card not present on Slot(3)
tg3 0000:0a:00.0: tg3_abort_hw timed out, TX_MODE_ENABLE will not
clear MAC_TX_MODE=ffffffff
tg3 0000:0a:00.0: eth1: No firmware running
tg3 0000:0a:00.0: eth1: Link is down
[sched_delayed] sched: RT throttling activated
pciehp 0000:09:00.0:pcie24: unloading service driver pciehp
INFO: task kworker/0:2:3072 blocked for more than 120 seconds.
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
kworker/0:2   D ffffffff8180cc20   0 3072   2 0x00000000
 ffff880237f75800 0000000000000046 0000000000000001 ffff880237f757b0
 ffff880237f75fd8 ffff880237f75fd8 ffff880237f75fd8 0000000000013940
 ffff88025f3b5c00 ffff880237eb5c00 0000000000000000 7fffffffffffffff
Call Trace:
 [<ffffffff816966e9>] schedule+0x29/0x70
 [<ffffffff81694e05>] schedule_timeout+0x2a5/0x320
 [<ffffffff81040af9>] ? default_spin_lock_flags+0x9/0x10
 [<ffffffff811ee0f9>] ? pde_put+0x79/0xa0
 [<ffffffff8169653f>] wait_for_common+0xdf/0x180
 [<ffffffff811ee0f9>] ? pde_put+0x79/0xa0
 [<ffffffff8108a360>] ? try_to_wake_up+0x200/0x200
 [<ffffffff816966bd>] wait_for_completion+0x1d/0x20
 [<ffffffff81070ec3>] flush_workqueue+0x143/0x400
 [<ffffffff8136d600>] ? pciehp_disable_slot+0x1f0/0x1f0
 [<ffffffff8136f986>] pciehp_release_ctrl+0x46/0xa0
 [<ffffffff8136c037>] pciehp_remove+0x27/0x30
 [<ffffffff81365167>] pcie_port_remove_service+0x57/0x70
 [<ffffffff81423abc>] __device_release_driver+0x7c/0xe0
 [<ffffffff81423b4c>] device_release_driver+0x2c/0x40
 [<ffffffff81423551>] bus_remove_device+0xe1/0x120
 [<ffffffff81365480>] ? resume_iter+0x40/0x40
 [<ffffffff81420d60>] device_del+0x120/0x1b0
 [<ffffffff81365480>] ? resume_iter+0x40/0x40
 [<ffffffff81420e06>] device_unregister+0x16/0x30
 [<ffffffff813654bd>] remove_iter+0x3d/0x50
 [<ffffffff8141fe64>] device_for_each_child+0x44/0x70
 [<ffffffff81365a16>] pcie_port_device_remove+0x26/0x40
 [<ffffffff81365b56>] pcie_portdrv_remove+0x16/0x30
 [<ffffffff8135e426>] pci_device_remove+0x46/0x110
 [<ffffffff81423abc>] __device_release_driver+0x7c/0xe0
 [<ffffffff81423b4c>] device_release_driver+0x2c/0x40
 [<ffffffff81423551>] bus_remove_device+0xe1/0x120
 [<ffffffff81420d60>] device_del+0x120/0x1b0
 [<ffffffff81420e06>] device_unregister+0x16/0x30
 [<ffffffff81357c64>] pci_stop_bus_device+0x94/0xa0
 [<ffffffff81357c13>] pci_stop_bus_device+0x43/0xa0
 [<ffffffff81357e16>] pci_stop_and_remove_bus_device+0x16/0x30
 [<ffffffff8136db61>] pciehp_unconfigure_device+0x91/0x190
 [<ffffffff8136d485>] pciehp_disable_slot+0x75/0x1f0
 [<ffffffff8136d6e3>] pciehp_power_thread+0xe3/0x110
 [<ffffffff81071a3a>] process_one_work+0x11a/0x480
 [<ffffffff81072ac5>] worker_thread+0x165/0x370
 [<ffffffff81072960>] ? manage_workers.isra.29+0x130/0x130
 [<ffffffff81077873>] kthread+0x93/0xa0
 [<ffffffff816a1164>] kernel_thread_helper+0x4/0x10
 [<ffffffff810777e0>] ? kthread_freezable_should_stop+0x70/0x70
 [<ffffffff816a1160>] ? gs_change+0x13/0x13
Daniel J Blueman
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Other Archives]     [Linux Kernel Newbies]     [Linux Driver Development]     [Linux Kbuild]     [Fedora Kernel]     [Linux Kernel Testers]     [Linux SH]     [Linux Omap]     [Linux Tape]     [Linux Input]     [Linux Kernel Janitors]     [Linux Kernel Packagers]     [Linux Doc]     [Linux Man Pages]     [Linux API]     [Linux Memory Management]     [Linux Modules]     [Linux Standards]     [Kernel Announce]     [Netdev]     [Git]     [Linux PCI]     Linux CAN Development     [Linux I2C]     [Linux RDMA]     [Linux NUMA]     [Netfilter]     [Netfilter Devel]     [SELinux]     [Bugtraq]     [FIO]     [Linux Perf Users]     [Linux Serial]     [Linux PPP]     [Linux ISDN]     [Linux Next]     [Kernel Stable Commits]     [Linux Tip Commits]     [Kernel MM Commits]     [Linux Security Module]     [AutoFS]     [Filesystem Development]     [Ext3 Filesystem]     [Linux bcache]     [Ext4 Filesystem]     [Linux BTRFS]     [Linux CEPH Filesystem]     [Linux XFS]     [XFS]     [Linux NFS]     [Linux CIFS]     [Ecryptfs]     [Linux NILFS]     [Linux Cachefs]     [Reiser FS]     [Initramfs]     [Linux FB Devel]     [Linux OpenGL]     [DRI Devel]     [Fastboot]     [Linux RT Users]     [Linux RT Stable]     [eCos]     [Corosync]     [Linux Clusters]     [LVS Devel]     [Hot Plug]     [Linux Virtualization]     [KVM]     [KVM PPC]     [KVM ia64]     [Linux Containers]     [Linux Hexagon]     [Linux Cgroups]     [Util Linux]     [Wireless]     [Linux Bluetooth]     [Bluez Devel]     [Ethernet Bridging]     [Embedded Linux]     [Barebox]     [Linux MMC]     [Linux IIO]     [Sparse]     [Smatch]     [Linux Arch]     [x86 Platform Driver]     [Linux ACPI]     [Linux IBM ACPI]     [LM Sensors]     [CPU Freq]     [Linux Power Management]     [Linmodems]     [Linux DCCP]     [Linux SCTP]     [ALSA Devel]     [Linux USB]     [Linux PA RISC]     [Linux Samsung SOC]     [MIPS Linux]     [IBM S/390 Linux]     [ARM Linux]     [ARM Kernel]     [ARM MSM]     [Tegra Devel]     [Sparc Linux]     [Linux Security]     [Linux Sound]     [Linux Media]     [Video 4 Linux]     [Linux IRDA Users]     [Linux for the blind]     [Linux RAID]     [Linux ATA RAID]     [Device Mapper]     [Linux SCSI]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Linux IDE]     [Linux SMP]     [Linux AXP]     [Linux Alpha]     [Linux M68K]     [Linux ia64]     [Linux 8086]     [Linux x86_64]     [Linux Config]     [Linux Apps]     [Linux MSDOS]     [Linux X.25]     [Linux Crypto]     [DM Crypt]     [Linux Trace Users]     [Linux Btrace]     [Linux Watchdog]     [Utrace Devel]     [Linux C Programming]     [Linux Assembly]     [Dash]     [DWARVES]     [Hail Devel]     [Linux Kernel Debugger]     [Linux gcc]     [Gcc Help]     [X.Org]     [Wine]

Add to Google Powered by Linux

[Older Kernel Discussion]     [Yosemite National Park Forum]     [Large Format Photos]     [Gimp]     [Yosemite Photos]     [Stuff]