Re: [PATCH 1/2] leds-clevo-mail: add MODULE_DEVICE_TABLE

[Bryan Wu <bryan.wu@xxxxxxxxxxxxx>]

On Thu, Aug 2, 2012 at 5:04 AM, Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx> wrote:
> Enable autoloading of leds-clevo-mail by using MODULE_DEVICE_TABLE.
>

Thanks, applied to my for-next branch
-Bryan

> Signed-off-by: Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx>
>
> --- a/drivers/leds/leds-clevo-mail.c
> +++ b/drivers/leds/leds-clevo-mail.c
> @@ -31,7 +31,7 @@ static int __init clevo_mail_led_dmi_callback(const struct dmi_system_id *id)
>  }
>
>  /*
> - * struct mail_led_whitelist - List of known good models
> + * struct clevo_mail_led_dmi_table - List of known good models
>   *
>   * Contains the known good models this driver is compatible with.
>   * When adding a new model try to be as strict as possible. This
> @@ -39,7 +39,7 @@ static int __init clevo_mail_led_dmi_callback(const struct dmi_system_id *id)
>   * detected as working, but in reality it is not) as low as
>   * possible.
>   */
> -static struct dmi_system_id __initdata mail_led_whitelist[] = {
> +static struct dmi_system_id __initdata clevo_mail_led_dmi_table[] = {
>         {
>                 .callback = clevo_mail_led_dmi_callback,
>                 .ident = "Clevo D410J",
> @@ -89,6 +89,7 @@ static struct dmi_system_id __initdata mail_led_whitelist[] = {
>         },
>         { }
>  };
> +MODULE_DEVICE_TABLE(dmi, clevo_mail_led_dmi_table);
>
>  static void clevo_mail_led_set(struct led_classdev *led_cdev,
>                                 enum led_brightness value)
> @@ -180,7 +181,7 @@ static int __init clevo_mail_led_init(void)
>
>         /* Check with the help of DMI if we are running on supported hardware */
>         if (!nodetect) {
> -               count = dmi_check_system(mail_led_whitelist);
> +               count = dmi_check_system(clevo_mail_led_dmi_table);
>         } else {
>                 count = 1;
>                 printk(KERN_ERR KBUILD_MODNAME ": Skipping DMI detection. "
>
>
>
>
> --
> Ondrej Zary



-- 
Bryan Wu <bryan.wu@xxxxxxxxxxxxx>
Kernel Developer    +86.186-168-78255 Mobile
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/