Re: [PATCH 13/13] perf, tool: Support for dwarf mode callchain on perf record

[David Ahern <dsahern@xxxxxxxxx>]

On 8/1/12 4:11 AM, Jiri Olsa wrote:
> +static int
> +parse_callchain_opt(const struct option *opt __used, const char *arg,
> +		    int unset)
> +{
> +	struct perf_record *rec = (struct perf_record *)opt->value;
> +	char *tok, *name, *saveptr = NULL;
> +	char buf[20];
> +	int ret = -1;
> +
> +	/* --no-call-graph */
> +	if (unset)
> +		return 0;
> +
> +	/* We specified default option if none is provided. */
> +	BUG_ON(!arg);
> +
> +	/* We need buffer that we know we can write to. */
> +	snprintf(buf, 20, "%s", arg);

Isn't arg the user supplied string? What if the user messes up and 
passes in 20+ characters to -g argument?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/