Re: [RFC ebeam PATCH 3/3] input: misc: New USB eBeam input driver.
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Hi Dmitry, >> +config INPUT_EBEAM_USB_CLASSIC >> + bool "eBeam Classic Projection support" >> + depends on INPUT_EBEAM_USB >> + default y > > Will there be support for other eBean devices (are there any)? If there > will how soon? How different are they? If not the we probably do not > need this INPUT_EBEAM_USB_CLASSIC selector. I know at least one re-branded same hardware by 3M, i will be able to borrow one in a month or so. According to the wikipedia article, there's probably more. There's also newer models and embeded ones in some video projector setup, also re-branded, based on the same technology and that might use the same type of protocol, but i can't be sure until someone can inspect them. These pieces of hardware are quite expensive, and mostly used in educational or corporate, they are not easy to grab. The code structure (device selector + functions indirection) also seems overkill to me for now, but permit to anticipate device's variations. If it appears that they all works in the same way, it'll be easy (and more comfortable to me) to step down, the opposite seems more difficult. >> +#define DEBUG > I do not think leaving DEBUG on is good idea for production code. Cinder, cleaned. >> +/* until KConfig */ >> +#define CONFIG_INPUT_EBEAM_USB_CLASSIC > > Huh? I test the module against my running kernel, building out of tree, and don't know how to define that in the makefile. This will be cleaned in final step. >> + bool irq_always; > > Does you device need this? Part of "overkill" foresight. >> + /* optional, model-specific */ >> + int (*alloc) (struct ebeam_device *ebeam); >> + int (*init) (struct ebeam_device *ebeam); >> + void (*exit) (struct ebeam_device *ebeam); > > Again, do you expect to see multitude of sufficiently different > devices or are they going to follow roughly the same protocol? ditto. -- Yann Cantin A4FEB47F -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[Other Archives] [Linux Kernel Newbies] [Linux Driver Development] [Linux Kbuild] [Fedora Kernel] [Linux Kernel Testers] [Linux SH] [Linux Omap] [Linux Tape] [Linux Input] [Linux Kernel Janitors] [Linux Kernel Packagers] [Linux Doc] [Linux Man Pages] [Linux API] [Linux Memory Management] [Linux Modules] [Linux Standards] [Kernel Announce] [Netdev] [Git] [Linux PCI] Linux CAN Development [Linux I2C] [Linux RDMA] [Linux NUMA] [Netfilter] [Netfilter Devel] [SELinux] [Bugtraq] [FIO] [Linux Perf Users] [Linux Serial] [Linux PPP] [Linux ISDN] [Linux Next] [Kernel Stable Commits] [Linux Tip Commits] [Kernel MM Commits] [Linux Security Module] [AutoFS] [Filesystem Development] [Ext3 Filesystem] [Linux bcache] [Ext4 Filesystem] [Linux BTRFS] [Linux CEPH Filesystem] [Linux XFS] [XFS] [Linux NFS] [Linux CIFS] [Ecryptfs] [Linux NILFS] [Linux Cachefs] [Reiser FS] [Initramfs] [Linux FB Devel] [Linux OpenGL] [DRI Devel] [Fastboot] [Linux RT Users] [Linux RT Stable] [eCos] [Corosync] [Linux Clusters] [LVS Devel] [Hot Plug] [Linux Virtualization] [KVM] [KVM PPC] [KVM ia64] [Linux Containers] [Linux Hexagon] [Linux Cgroups] [Util Linux] [Wireless] [Linux Bluetooth] [Bluez Devel] [Ethernet Bridging] [Embedded Linux] [Barebox] [Linux MMC] [Linux IIO] [Sparse] [Smatch] [Linux Arch] [x86 Platform Driver] [Linux ACPI] [Linux IBM ACPI] [LM Sensors] [CPU Freq] [Linux Power Management] [Linmodems] [Linux DCCP] [Linux SCTP] [ALSA Devel] [Linux USB] [Linux PA RISC] [Linux Samsung SOC] [MIPS Linux] [IBM S/390 Linux] [ARM Linux] [ARM Kernel] [ARM MSM] [Tegra Devel] [Sparc Linux] [Linux Security] [Linux Sound] [Linux Media] [Video 4 Linux] [Linux IRDA Users] [Linux for the blind] [Linux RAID] [Linux ATA RAID] [Device Mapper] [Linux SCSI] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Linux IDE] [Linux SMP] [Linux AXP] [Linux Alpha] [Linux M68K] [Linux ia64] [Linux 8086] [Linux x86_64] [Linux Config] [Linux Apps] [Linux MSDOS] [Linux X.25] [Linux Crypto] [DM Crypt] [Linux Trace Users] [Linux Btrace] [Linux Watchdog] [Utrace Devel] [Linux C Programming] [Linux Assembly] [Dash] [DWARVES] [Hail Devel] [Linux Kernel Debugger] [Linux gcc] [Gcc Help] [X.Org] [Wine]
[Older Kernel Discussion] [Yosemite National Park Forum] [Large Format Photos] [Gimp] [Yosemite Photos] [Stuff]