Re: [PATCH] regulator: arizona: Add support for microphone supplies on Arizona devices

[Axel Lin <axel.lin@xxxxxxxxx>]

> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -88,6 +88,13 @@ config REGULATOR_AAT2870
>          If you have a AnalogicTech AAT2870 say Y to enable the
>          regulator driver.
>
> +config REGULATOR_ARIZONA
> +       tristate "Wolfson Arizona class devices"
> +       depends on MFD_ARIZONA
> +       help
> +         Support for the regulators found on Wolfson Arizona class
> +         devices.
> +

I think you may want to put this Kconfig entriy along with other
Wolfson Microelectronics chips. So all Wolfson chips show in a group.

BTW, seems the MFD_ARIZONA patchs are not (yet) available in LKML.

> +static int arizona_micsupp_map_voltage(struct regulator_dev *rdev,
> +                                      int min_uV, int max_uV)
> +{
> +       unsigned int voltage;
> +       int selector;
> +
> +       if (min_uV < 1700000)
> +               min_uV = 1700000;
> +
> +       if (min_uV >= 3300000)
> +               selector = ARIZONA_MICSUPP_MAX_SELECTOR;
> +       else
> +               selector = DIV_ROUND_UP(min_uV - 1700000, 50000);
> +
> +       if (selector < 0)
> +               return -EINVAL;
I think you don't need this checking. You already ensure min_uV >= 1700000.

The rest of the code looks good to me.
Reviewed-by: Axel Lin <axel.lin@xxxxxxxxx>

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/