Re: [PATCH] Perf: Use /usr/bin/pager if available for perf pager

[Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>]

On Tue, 29 May 2012 16:05:25 +0530
Avik Sil <avik.sil@xxxxxxxxxx> wrote:

> Some Distributions may lack "less" package being included by default, e.g., Linaro nano rootfs. In those cases use the portable "pager" command instead of "less".
> 
> Signed-off-by: Avik Sil <avik.sil@xxxxxxxxxx>
> ---
>  tools/perf/util/pager.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/perf/util/pager.c b/tools/perf/util/pager.c
> index 1915de2..3322b84 100644
> --- a/tools/perf/util/pager.c
> +++ b/tools/perf/util/pager.c
> @@ -57,6 +57,10 @@ void setup_pager(void)
>  	}
>  	if (!pager)
>  		pager = getenv("PAGER");
> +	if (!pager) {
> +		if (!access("/usr/bin/pager", X_OK))
> +			pager = "/usr/bin/pager";
> +	}

What is "portable" about /usr/bin/pager ? and what is wrong with just
doing

export PAGER=/usr/bin/pager

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/