* H. Peter Anvin <hpa@xxxxxxxxx> wrote: > On 05/23/2012 10:07 AM, Linus Torvalds wrote: > > On Wed, May 23, 2012 at 4:34 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote: > >> > >> Sasha Levin (1): > >> x86, printk: Add missing KERN_CONT to NMI selftest > > > > Why? This seems to be garbage. > > > > This was added to the urgent branch earlier (but it wasn't > worth pushing late in rc) but apparently a more underlying bug > was fixed in the meantime. > > It didn't seem worth removing since the KERN_CONT should > really be there anyway. I'm not sure it should be there: if there's no KERN_ prefix in a printk, and the previous printk from this context did not end with \n, then the KERN_CONT should be implicit. KERN_CONT is really special, for rare cases where you want to explicitly avoid the <> priority field or to construct it. Or at least that's how I understand this area, it might have been updated meanwhile - Linus? Also, we can rebase the whole branch and get rid of this one and of the merge commit it has. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/