Re: [PATCH 2/2] coccinelle: semantic patch for simple_open()

[Stephen Boyd <sboyd@xxxxxxxxxxxxxx>]

On 03/03/12 04:10, Julia Lawall wrote:
> On Sat, 3 Mar 2012, Stephen Boyd wrote:
>
> > Find instances of an open-coded simple_open() and replace them
> > with calls to simple_open().
> >
> > Cc: Julia Lawall <Julia.Lawall@xxxxxxx>
> > Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> > ---
> >
> > This seems to eat the definition of simple_open() as well. Is there
> > a way to say only remove both the function and the reference to
> > the function so that libfs survives?
>
> Try identifier open_f != simple_open;

Ah thanks. That works.

> Is there a header file that should be present?

It would be <include/fs.h> which should already be there if there is a 
file_operations structure.

> Your transformation rules should include depends on patch in the very 
> first line, after the rule name.
>
> Can you make a report rule?  If not, I will do it.  Someone asked for 
> that to always be present.

I tried but failed. I get:

nit_defs_builtins: /usr/share/coccinelle/standard.h
between: p start 15 p end 15 m1 start 15 m1 end 15 m2 start 15 m2 end 15

  -int -open:open_f-struct -inode -*-open:i-, -struct -file -*-open:f
Fatal error: exception Failure("The semantic patch is structured in a 
way that may give bad results with isomorphisms.  Please try to rewrite 
it by moving + code out from -/context terms.")

When I add this:

@r1 depends on org || report @
identifier open_f != simple_open;
identifier i, f;
position p1;
@@
 int open_f@p1(struct inode *i, struct file *f)
 {
(
 if (i->i_private)
 f->private_data = i->i_private;
|
 f->private_data = i->i_private;
)
 return 0;
 }

@script:python depends on org@
p1 << r1.p1;
@@

cocci.print_main("extra function",p1)


Any ideas what's wrong?

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/