Re: [PATCH 39/39] x86, PCI: kill busn in acpi pci_root_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, Feb 29, 2012 at 03:37:53PM -0800, Yinghai Lu wrote:
> On Wed, Feb 29, 2012 at 3:32 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> > On Wed, Feb 29, 2012 at 4:07 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> >> Bjorn thought that we should just use that in acpi_root.
> >>
> >> Suggested-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> >> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> >> ---
> >>  arch/x86/pci/acpi.c |   19 ++++++-------------
> >>  1 files changed, 6 insertions(+), 13 deletions(-)
> >>
> >> diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c
> >> index ff5243e..5178917 100644
> >> --- a/arch/x86/pci/acpi.c
> >> +++ b/arch/x86/pci/acpi.c
> >> @@ -12,7 +12,6 @@ struct pci_root_info {
> >>        char name[16];
> >>        unsigned int res_num;
> >>        struct resource *res;
> >> -       struct resource busn;
> >>        struct pci_sysdata sd;
> >>  };
> >>
> >> @@ -283,9 +282,6 @@ static void add_resources(struct pci_root_info *info,
> >>        int i;
> >>        struct resource *res, *root, *conflict;
> >>
> >> -       if (info->busn.flags & IORESOURCE_BUS)
> >> -               pci_add_resource(resources, &info->busn);
> >> -
> >>        coalesce_windows(info, IORESOURCE_MEM);
> >>        coalesce_windows(info, IORESOURCE_IO);
> >>
> >> @@ -346,16 +342,12 @@ static void release_pci_root_info(struct pci_host_bridge *bridge)
> >>
> >>  static void
> >>  probe_pci_root_info(struct pci_root_info *info, struct acpi_device *device,
> >> -                   int busnum, int busmax, int domain)
> >> +                   int busnum, int domain)
> >>  {
> >>        size_t size;
> >>
> >>        sprintf(info->name, "PCI Bus %04x:%02x", domain, busnum);
> >>        info->bridge = device;
> >> -       info->busn.name = info->name;
> >> -       info->busn.start = busnum;
> >> -       info->busn.end = busmax;
> >> -       info->busn.flags = IORESOURCE_BUS;
> >
> > You just *added* this stuff in a prior patch that hasn't been merged
> > yet.  Why can't you just fix that series rather than doing the
> > add/remove churn?
> 
> as i said before, I'm not quite sure about the life cycle about that object.
> 
> still need to wait some months to verify that on system that does
> support pci root bus hot plug etc.
> 
> or we can just this patch for now.

A statement like that would cause all of these patches to be instantly
deleted from any queue that I had control over, and I strongly recommend
that Jesse just ignore them all.

If you don't know this thing, then you have no right to change it, flat
out.  Why do we trust these patches from you?  I sure don't.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[Other Archives]     [Linux Kernel Newbies]     [Linux Driver Development]     [Fedora Kernel]     [Linux Kernel Testers]     [Linux SH]     [Linux Omap]     [Linux Kbuild]     [Linux Tape]     [Linux Input]     [Linux Kernel Janitors]     [Linux Kernel Packagers]     [Linux Doc]     [Linux Man Pages]     [Linux API]     [Linux Memory Management]     [Linux Modules]     [Linux Standards]     [Kernel Announce]     [Netdev]     [Git]     [Linux PCI]     Linux CAN Development     [Linux I2C]     [Linux RDMA]     [Linux NUMA]     [Netfilter]     [Netfilter Devel]     [SELinux]     [Bugtraq]     [FIO]     [Linux Perf Users]     [Linux Serial]     [Linux PPP]     [Linux ISDN]     [Linux Next]     [Kernel Stable Commits]     [Linux Tip Commits]     [Kernel MM Commits]     [Linux Security Module]     [Filesystem Development]     [Ext3 Filesystem]     [Linux bcache]     [Ext4 Filesystem]     [Linux BTRFS]     [Linux CEPH Filesystem]     [Linux XFS]     [XFS]     [Linux NFS]     [Linux CIFS]     [Ecryptfs]     [Linux NILFS]     [Linux Cachefs]     [Reiser FS]     [Initramfs]     [Linux FB Devel]     [Linux OpenGL]     [DRI Devel]     [Fastboot]     [Linux RT Users]     [Linux RT Stable]     [eCos]     [Corosync]     [Linux Clusters]     [LVS Devel]     [Hot Plug]     [Linux Virtualization]     [KVM]     [KVM PPC]     [KVM ia64]     [Linux Containers]     [Linux Hexagon]     [Linux Cgroups]     [Util Linux]     [Wireless]     [Linux Bluetooth]     [Bluez Devel]     [Ethernet Bridging]     [Embedded Linux]     [Barebox]     [Linux MMC]     [Linux IIO]     [Sparse]     [Smatch]     [Linux Arch]     [x86 Platform Driver]     [Linux ACPI]     [Linux IBM ACPI]     [LM Sensors]     [CPU Freq]     [Linux Power Management]     [Linmodems]     [Linux DCCP]     [Linux SCTP]     [ALSA Devel]     [Linux USB]     [Linux PA RISC]     [Linux Samsung SOC]     [MIPS Linux]     [IBM S/390 Linux]     [ARM Linux]     [ARM Kernel]     [ARM MSM]     [Tegra Devel]     [Sparc Linux]     [Linux Security]     [Linux Sound]     [Linux Media]     [Video 4 Linux]     [Linux IRDA Users]     [Linux for the blind]     [Linux RAID]     [Linux ATA RAID]     [Device Mapper]     [Linux SCSI]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Linux IDE]     [Linux SMP]     [Linux AXP]     [Linux Alpha]     [Linux M68K]     [Linux ia64]     [Linux 8086]     [Linux x86_64]     [Linux Config]     [Linux Apps]     [Linux MSDOS]     [Linux X.25]     [Linux Crypto]     [DM Crypt]     [Linux Trace Users]     [Linux Btrace]     [Linux Watchdog]     [Utrace Devel]     [Linux C Programming]     [Linux Assembly]     [Dash]     [DWARVES]     [Hail Devel]     [Linux Kernel Debugger]     [Linux gcc]     [Gcc Help]     [X.Org]     [Wine]

Add to Google Powered by Linux

[Older Kernel Discussion]     [Yosemite National Park Forum]     [Large Format Photos]     [Gimp]     [Yosemite Photos]     [Stuff]