Re: [PATCH 1/3] mce: Add a msg string to the MCE tracepoint

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Em 29-02-2012 14:20, Luck, Tony escreveu:
>> IMHO, before removing those fields, it would be better to first implement
>> what is there at the mcelog userspace parser for the Intel machines into
>> kernelspace (or to look into its source code), and check what registers
>> aren't used by either AMD 64 MCE decoder or by the Intel MCE decoder.
>>
>> Tony,
>>
>> Is there anyone at Intel working on porting it to kernelspace?
> 
> The mcelog code just looks at model specific fields in MCi_STATUS
> and MCi_MISC.  We could move it to the kernel - but I don't see
> much value in doing so. 

I see a few reasons:

	- it would be consistent with what's being done at AMD. So, all x86
	  arch will report errors at the same way;

	- userspace won't need to run an extra daemon/tool to decode the
	  errors;

	- fatal errors won't be lost (well, in fact, you have there already 
	  a parser for fatal errors. Not sure if all possible fatal errors
	  are covered here, nor what else is needed, as you have already 
	  there part of mcelog decoder);

	- a single place to maintain, when new cpu families are added;

	- it makes easier to centralize the hardware error information,
	  as there's no need to enrich the error on userspace.

> In this case all the information we need
> is carried in status/misc - so as long as we keep all of those
> bits (and the cpu family/model) we can safely decode/analyze later.

Hmm... the mcelog tool opens the /proc/cpuinfo:

$ grep cpuinfo *
mcelog.c:	f = fopen("/proc/cpuinfo","r");
mcelog.c:			Eprintf("warning: Cannot parse /proc/cpuinfo\n"); 
mcelog.c:		Eprintf("warning: Cannot open /proc/cpuinfo\n");
tsc.c:	asprintf(&fn, "/sys/devices/system/cpu/cpu%d/cpufreq/cpuinfo_max_freq", cpu);
tsc.c:		/* /sys exists, but no cpufreq -- use value from cpuinfo */

That probably means that the needed cpu family/model info is not (or may not) be
stored at the MCE structure.

> 
> -Tony

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[Other Archives]     [Linux Kernel Newbies]     [Linux Driver Development]     [Fedora Kernel]     [Linux Kernel Testers]     [Linux SH]     [Linux Omap]     [Linux Kbuild]     [Linux Tape]     [Linux Input]     [Linux Kernel Janitors]     [Linux Kernel Packagers]     [Linux Doc]     [Linux Man Pages]     [Linux API]     [Linux Memory Management]     [Linux Modules]     [Linux Standards]     [Kernel Announce]     [Netdev]     [Git]     [Linux PCI]     Linux CAN Development     [Linux I2C]     [Linux RDMA]     [Linux NUMA]     [Netfilter]     [Netfilter Devel]     [SELinux]     [Bugtraq]     [FIO]     [Linux Perf Users]     [Linux Serial]     [Linux PPP]     [Linux ISDN]     [Linux Next]     [Kernel Stable Commits]     [Linux Tip Commits]     [Kernel MM Commits]     [Linux Security Module]     [Filesystem Development]     [Ext3 Filesystem]     [Linux bcache]     [Ext4 Filesystem]     [Linux BTRFS]     [Linux CEPH Filesystem]     [Linux XFS]     [XFS]     [Linux NFS]     [Linux CIFS]     [Ecryptfs]     [Linux NILFS]     [Linux Cachefs]     [Reiser FS]     [Initramfs]     [Linux FB Devel]     [Linux OpenGL]     [DRI Devel]     [Fastboot]     [Linux RT Users]     [Linux RT Stable]     [eCos]     [Corosync]     [Linux Clusters]     [LVS Devel]     [Hot Plug]     [Linux Virtualization]     [KVM]     [KVM PPC]     [KVM ia64]     [Linux Containers]     [Linux Hexagon]     [Linux Cgroups]     [Util Linux]     [Wireless]     [Linux Bluetooth]     [Bluez Devel]     [Ethernet Bridging]     [Embedded Linux]     [Barebox]     [Linux MMC]     [Linux IIO]     [Sparse]     [Smatch]     [Linux Arch]     [x86 Platform Driver]     [Linux ACPI]     [Linux IBM ACPI]     [LM Sensors]     [CPU Freq]     [Linux Power Management]     [Linmodems]     [Linux DCCP]     [Linux SCTP]     [ALSA Devel]     [Linux USB]     [Linux PA RISC]     [Linux Samsung SOC]     [MIPS Linux]     [IBM S/390 Linux]     [ARM Linux]     [ARM Kernel]     [ARM MSM]     [Tegra Devel]     [Sparc Linux]     [Linux Security]     [Linux Sound]     [Linux Media]     [Video 4 Linux]     [Linux IRDA Users]     [Linux for the blind]     [Linux RAID]     [Linux ATA RAID]     [Device Mapper]     [Linux SCSI]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Linux IDE]     [Linux SMP]     [Linux AXP]     [Linux Alpha]     [Linux M68K]     [Linux ia64]     [Linux 8086]     [Linux x86_64]     [Linux Config]     [Linux Apps]     [Linux MSDOS]     [Linux X.25]     [Linux Crypto]     [DM Crypt]     [Linux Trace Users]     [Linux Btrace]     [Linux Watchdog]     [Utrace Devel]     [Linux C Programming]     [Linux Assembly]     [Dash]     [DWARVES]     [Hail Devel]     [Linux Kernel Debugger]     [Linux gcc]     [Gcc Help]     [X.Org]     [Wine]

Add to Google Powered by Linux

[Older Kernel Discussion]     [Yosemite National Park Forum]     [Large Format Photos]     [Gimp]     [Yosemite Photos]     [Stuff]