RE: [PATCH 2/3] x86, RAS: Add a decoded msg buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+	if (left <= 50) {
+		/* enlarge arbitrarily by 50 chars */
+		err_str_sz += 50;
+		left += 50;
+
+		err_str = krealloc(err_str, err_str_sz, GFP_KERNEL);
+		if (!err_str) {
+			pr_err("Error enlarging decode buffer.\n");
+			return;
+		}
+	}

This looks worrying to me.  Some bad stuff has happened, we are perhaps
in machine check context, and you want to start allocating memory!

Is there some upper bound for how long this string can get? Why not
just allocate a generous amount at boot time?

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[Index of Archives]

  Powered by Linux

[Older Kernel Discussion]     [Yosemite National Park Forum]     [Large Format Photos]     [Gimp]     [Yosemite Photos]     [Stuff]     [Index of Other Archives]