Re: [PATCH V2 2/3] bluetooth: Convert BT_ERR/BT_INFO to bt_err/bt_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hi,

> > Use the more common kernel style functions rather than
> > an upper case macro.
> > 
> > Add newlines to end of formats.
> > Coalesce formats, align arguments.
> > 
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> > ---
> >  drivers/bluetooth/ath3k.c          |   46 +++++++-------
> >  drivers/bluetooth/bcm203x.c        |   24 ++++----
> >  drivers/bluetooth/bfusb.c          |   67 +++++++++++---------
> >  drivers/bluetooth/bluecard_cs.c    |   17 +++---
> >  drivers/bluetooth/bpa10x.c         |   18 +++---
> >  drivers/bluetooth/bt3c_cs.c        |   36 ++++++-----
> >  drivers/bluetooth/btmrvl_debugfs.c |    2 +-
> >  drivers/bluetooth/btmrvl_main.c    |   39 ++++++------
> >  drivers/bluetooth/btmrvl_sdio.c    |  122 +++++++++++++++++-------------------
> >  drivers/bluetooth/btsdio.c         |    2 +-
> >  drivers/bluetooth/btuart_cs.c      |   23 ++++---
> >  drivers/bluetooth/btusb.c          |   38 ++++++------
> >  drivers/bluetooth/btwilink.c       |   29 ++++-----
> >  drivers/bluetooth/dtl1_cs.c        |   19 +++---
> >  drivers/bluetooth/hci_ath.c        |    6 +-
> >  drivers/bluetooth/hci_bcsp.c       |   50 ++++++++-------
> >  drivers/bluetooth/hci_h4.c         |    8 +-
> >  drivers/bluetooth/hci_ldisc.c      |   14 ++--
> >  drivers/bluetooth/hci_ll.c         |   33 ++++++----
> >  drivers/bluetooth/hci_vhci.c       |    6 +-
> >  include/net/bluetooth/hci_core.h   |    6 +-
> >  net/bluetooth/af_bluetooth.c       |    4 +-
> >  net/bluetooth/bnep/core.c          |    4 +-
> >  net/bluetooth/bnep/netdev.c        |    2 +-
> >  net/bluetooth/bnep/sock.c          |    4 +-
> >  net/bluetooth/cmtp/capi.c          |   19 +++---
> >  net/bluetooth/cmtp/core.c          |    8 +-
> >  net/bluetooth/cmtp/sock.c          |    4 +-
> >  net/bluetooth/hci_core.c           |   24 ++++----
> >  net/bluetooth/hci_event.c          |   16 +++---
> >  net/bluetooth/hci_sock.c           |    6 +-
> >  net/bluetooth/hci_sysfs.c          |    2 +-
> >  net/bluetooth/hidp/core.c          |   14 +++--
> >  net/bluetooth/hidp/sock.c          |    4 +-
> >  net/bluetooth/l2cap_core.c         |   32 +++++-----
> >  net/bluetooth/l2cap_sock.c         |    6 +-
> >  net/bluetooth/mgmt.c               |    6 +-
> >  net/bluetooth/rfcomm/core.c        |   16 +++---
> >  net/bluetooth/rfcomm/sock.c        |    8 +-
> >  net/bluetooth/rfcomm/tty.c         |   18 +++---
> >  net/bluetooth/sco.c                |    8 +-
> >  net/bluetooth/smp.c                |   14 ++--
> >  42 files changed, 419 insertions(+), 405 deletions(-)
> 
> I leave this up to Johan if he can get it merged without having to redo
> the patch. Otherwise it might have to wait a little bit.
> 
> If you would split drivers/ from include/ and net/ I think it has more
> likelihood that at least that one can be merged easily.
> 
> Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>

Patches 2/3 and 3/3 have never actually made it to the linux-bluetooth
list (I've never seen them and they're not visible in the archives
either). Doing the split like Marcel proposes would probably solve the
issue since I'm guessing the large message size is to blame.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[Other Archives]     [Linux Kernel Newbies]     [Linux Driver Development]     [Fedora Kernel]     [Linux Kernel Testers]     [Linux SH]     [Linux Omap]     [Linux Kbuild]     [Linux Tape]     [Linux Input]     [Linux Kernel Janitors]     [Linux Kernel Packagers]     [Linux Doc]     [Linux Man Pages]     [Linux API]     [Linux Memory Management]     [Linux Modules]     [Linux Standards]     [Kernel Announce]     [Netdev]     [Git]     [Linux PCI]     Linux CAN Development     [Linux I2C]     [Linux RDMA]     [Linux NUMA]     [Netfilter]     [Netfilter Devel]     [SELinux]     [Bugtraq]     [FIO]     [Linux Perf Users]     [Linux Serial]     [Linux PPP]     [Linux ISDN]     [Linux Next]     [Kernel Stable Commits]     [Linux Tip Commits]     [Kernel MM Commits]     [Linux Security Module]     [Filesystem Development]     [Ext3 Filesystem]     [Linux bcache]     [Ext4 Filesystem]     [Linux BTRFS]     [Linux CEPH Filesystem]     [Linux XFS]     [XFS]     [Linux NFS]     [Linux CIFS]     [Ecryptfs]     [Linux NILFS]     [Linux Cachefs]     [Reiser FS]     [Initramfs]     [Linux FB Devel]     [Linux OpenGL]     [DRI Devel]     [Fastboot]     [Linux RT Users]     [Linux RT Stable]     [eCos]     [Corosync]     [Linux Clusters]     [LVS Devel]     [Hot Plug]     [Linux Virtualization]     [KVM]     [KVM PPC]     [KVM ia64]     [Linux Containers]     [Linux Hexagon]     [Linux Cgroups]     [Util Linux]     [Wireless]     [Linux Bluetooth]     [Bluez Devel]     [Ethernet Bridging]     [Embedded Linux]     [Barebox]     [Linux MMC]     [Linux IIO]     [Sparse]     [Smatch]     [Linux Arch]     [x86 Platform Driver]     [Linux ACPI]     [Linux IBM ACPI]     [LM Sensors]     [CPU Freq]     [Linux Power Management]     [Linmodems]     [Linux DCCP]     [Linux SCTP]     [ALSA Devel]     [Linux USB]     [Linux PA RISC]     [Linux Samsung SOC]     [MIPS Linux]     [IBM S/390 Linux]     [ARM Linux]     [ARM Kernel]     [ARM MSM]     [Tegra Devel]     [Sparc Linux]     [Linux Security]     [Linux Sound]     [Linux Media]     [Video 4 Linux]     [Linux IRDA Users]     [Linux for the blind]     [Linux RAID]     [Linux ATA RAID]     [Device Mapper]     [Linux SCSI]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Linux IDE]     [Linux SMP]     [Linux AXP]     [Linux Alpha]     [Linux M68K]     [Linux ia64]     [Linux 8086]     [Linux x86_64]     [Linux Config]     [Linux Apps]     [Linux MSDOS]     [Linux X.25]     [Linux Crypto]     [DM Crypt]     [Linux Trace Users]     [Linux Btrace]     [Linux Watchdog]     [Utrace Devel]     [Linux C Programming]     [Linux Assembly]     [Dash]     [DWARVES]     [Hail Devel]     [Linux Kernel Debugger]     [Linux gcc]     [Gcc Help]     [X.Org]     [Wine]

Add to Google Powered by Linux

[Older Kernel Discussion]     [Yosemite National Park Forum]     [Large Format Photos]     [Gimp]     [Yosemite Photos]     [Stuff]