On Thu, Feb 16, 2012 at 06:40:47PM +0100, Oleg Nesterov wrote: > On 02/16, Cyrill Gorcunov wrote: > > > > -static void access_unlock(struct task_struct *task) > > +static void kcmp_unlock(struct mutex *m1, struct mutex *m2) > > { > > - mutex_unlock(&task->signal->cred_guard_mutex); > > + if (m2 > m1) > > + swap(m1, m2); > > Well, the order doesn't matter in case of _unlock, you can remove > this part. Not that it really hurts though, I won't argue. > It drops some instructions so I think it worth removing (still unlocking not in reverse order is something which always make me nervious ;) Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/