[PATCH] Add support for USB Keyboard attached to UHCI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Aaron Young wrote:

Hi Aaron and Konstantin,

> 
> 
> 
>   I guess I'm good with it. Couple of nits:
> 
> 1. The routine kdb_uhci_keyboard_urb() is really not uhci specific
>    and so could be renamed to simply kdb_keyboard_urb(). Or

We now have three copies of kdb_usb_kdbs[], kdb_usb_keycode[], and
kdb_uhci_keyboard_urb().

We need separate kdb_uhci_keyboard_urb() because we have  three arch-
dependent kdb_usb_kbds[]. My brief examination seems to indicate
they are the same. Do we need to have arch-depedent kdb_usb_kbds[]?
Also, do we need three copies of kdb_usb_keycode[]?

Thanks,
 - jay

>    kdb_get_urb() or kdb_get_urb_index() perhaps to be more descriptive.
>    kdb_uhci_keyboard_urb() sounds like it should return a BOOLEAN.
> 
---------------------------
Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux