[PATCH] Add support for USB Keyboard attached to UHCI
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
> > On Fri, 30 Nov 2007 09:00:50 -0800 (PST) Aaron Young wrote: > > > > > > > Another thing, I think we need to update these files: > > > > arch/ia64/Kconfig.debug > > arch/x86/Kconfig.debug > > > > to change this line: > > depends on KDB && USB_OHCI_HCD > > > > to: > > > > depends on KDB && USB_OHCI_HCD && USB_UHCI_HCD && USB_EHCI_HCD > > I don't have the complete patch in front of me, but why would > all 3 of those HCDs be needed? I would expect it to be more like > > depends on KDB && (USB_OHCI_HCD || USB_UHCI_HCD) > > and even omit the EHCI_HCD part since it is only for high-speed > devices and I've never seen a keyboard that is a high-speed USB > device. EHCI HCD will be used if a keyboard is attached via a USB2.0 hub. Perhaps "depends on KDB && (USB_OHCI_HCD || USB_UHCI_HCD || USB_EHCI_HCD)" would be better... What led me to this is Konstantin added this field to a KDB private header struct: + struct uhci_qh *qh; Would this compile properly without USB_UHCI_HCD defined (i.e. and the UHCI HCD was not included in the build?) Also, what if the USB HCDs where compiled as separate modules instead of statically linked? Does it (KDB) still compile okay? Seems like we may need a "#include <uhci-hcd.>" in this file... (?) Or, perhaps make it a "void *" and cast it to a struct uhci_qh from the USB kernel files before it's actually used? -Aaron --------------------------- Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.