[patch] Fix some problem between kdb and kdump
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
* Keith Owens <kaos at sgi.com> [2007-06-01 02:37]: > Takenori Nagano (on Thu, 31 May 2007 16:37:59 +0900) wrote: > >Hi, > > > >kdb has some problem to use with kdump. > >This patch fixes some of them. > > > >1) We can't use kdb when machine panicked. > > > >crash_kexec() is called before notifier_call_chain(&panic_notifier_chain)= > >. > >This patch makes KDB_ENTER() is called before crash_kexec(). > > Both KDB and crash_kexec should be using the panic_notifier_chain, with > KDB having a higher priority than crash_exec. The whole point of > notifier chains is to handle cases like this, so we should not be > adding more code to the panic routine. That's true. But the problem is: KDB is not mainline while kdump is. So, if mainline doesn't accept changes for some reason, the changes must be included in KDB patches. :-( > >2) We can't take a kdump when KDB_FLAG is set CATASTROPHIC. > > > >kdb_do_dump() does not support kdump. > >This patch makes machine_kexec() is called from kdb_do_dump(). > > Ugly. All the code for selecting which dump to take (lkcd, kexec, > anything else) should be in a common kernel routine that anybody can > call. It should not be just in KDB. Well, but if KDB is *disabled*, there should be a way that KDB just doesn't do anything. It would help if CONFIG_KDB_CONTINUE_CATASTROPHIC would be a *runtime* setting, not a *compile time* setting. Thanks, Bernhard --------------------------- Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.