Re: In regard of commit "gudev: Use strtoul to parse unsigned 64-bit integers"
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On Mon, Oct 31, 2011 at 5:04 PM, Rafał Mużyło <galtgendo@xxxxxxxxx> wrote: > On Mon, Oct 31, 2011 at 04:32:07PM -0400, David Zeuthen wrote: >> On Mon, Oct 31, 2011 at 4:13 PM, Rafał Mużyło <galtgendo@xxxxxxxxx> wrote: >> > Perhaps I'm simply misreading something, but won't going from strtoll to >> > strtoul break things for 32bit case ? >> >> What do you think it would break? Or are you perhaps suggesting we >> should be using strtoull() instead? Please be specific. >> > Well, given on what happens on strtoul overflow according to the > manpage... Well, the problem was simply that I just missed an 'l' in the initial patch and that mistake breaks 32-bit as you tried to point out. The patch I just sent fixes the problem. Sigh, this is what happens when people try to make their function names as short as possible... never a good idea. David -- To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html