Re: In regard of commit "gudev: Use strtoul to parse unsigned 64-bit integers"
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On Mon, Oct 31, 2011 at 04:32:07PM -0400, David Zeuthen wrote: > On Mon, Oct 31, 2011 at 4:13 PM, Rafał Mużyło <galtgendo@xxxxxxxxx> wrote: > > Perhaps I'm simply misreading something, but won't going from strtoll to > > strtoul break things for 32bit case ? > > What do you think it would break? Or are you perhaps suggesting we > should be using strtoull() instead? Please be specific. > Well, given on what happens on strtoul overflow according to the manpage... But, as you're the main author of udisks, would you mind looking at the bug I've mentioned ? Perhaps it doesn't matter there, but it would be good to do something about the warnings. -- To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html