[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch 1/3] CLD: End-to-end verbosity v3



On 04/13/2010 04:30 PM, Pete Zaitcev wrote:
It has been observed that it's not possible to enable the session-level
verbose dump with -v switch of cldcli anymore (post XDR and ncld).

The main issue is that it is impossible to set the session verbosity by
an application control. Secondary issue is that if application attempts
to change the verbosity level, it cannot do so for newly-created sessions,
because the session structure is allocated when session is created.

Contributing to the confusion is the desire not to enable excessive
verbosity in the CLD sessions whenever debugging is requested.

To fix these issues, the patch does the following:

  - Drops all commented-out inserts that assign additional verbosity
    from libraries. Permits top-level applications to specify verbosity
    (what cldcli -v was intended to do).

  - Splits per-packet verbosity away from debugging messages.

  - Establishes -D 2 to mean "CLD protocol verbosity" across applications
    and the daemon (this replaces the "old" -v). The existing -D 1 now
    controls the program debugging only, and there is no bit mask.

Coincidentially this fixes the crash whenever there's a resolution
failure for an SRV record.

Signed-Off-By: Pete Zaitcev<zaitcev@xxxxxxxxxx>

---
  include/cldc.h       |    1
  include/hail_log.h   |   24 +++++----
  include/ncld.h       |    2
  lib/cldc.c           |  104 ++++++++++++++++++++++++-----------------
  pkg/cld.sysconf      |    2
  server/server.c      |   19 ++++---
  test/basic-io.c      |    4 -
  test/basic-session.c |    2
  test/lock-file.c     |    2
  tools/cldcli.c       |   17 +++---
  tools/cldfuse.c      |    2
  11 files changed, 104 insertions(+), 75 deletions(-)

applied, thanks for the revisions

Long term, I think the per-packet session logging macro should be made more clear, perhaps calling it HAIL_SESS or even HAIL_PKT

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe hail-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux