[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch 1/1] CLD: Introduce the "New CLD" API



On Mon, 08 Feb 2010 21:06:17 -0500
Jeff Garzik <jeff@xxxxxxxxxx> wrote:

> > -	if (cldc_getaddr(&host_list, hostb, NULL))
> > +	if (cldc_getaddr(&host_list, hostb, &ncld_log))
> >   		return 1001;

> Logging pointer should be supplied by the caller...  that is the larger 
> bug.  Needing a no-op log function is just an indication of that.

I did it before, but then every client, without exception, needed
to include <stdarg.h> and provide the log. And what for? This is
STUPID and proof is in the pudding: your getsrvinfo does not do
anything of the sort. Might as well replace cldc_getadd with getsrvinfo
and then everyone becomes happy.

-- Pete
--
To unsubscribe from this list: send the line "unsubscribe hail-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux