Re: [Patch 1/3] tabled: make time2str reentrant

[Jeff Garzik <jeff@xxxxxxxxxx>]

On 01/03/2010 03:34 AM, Pete Zaitcev wrote:
> On Sun, 03 Jan 2010 03:27:59 -0500
> Jeff Garzik<jeff@xxxxxxxxxx>  wrote:
>
> > > -	sprintf(datestr, "Date: %s", time2str(timestr, time(NULL)));
> > > +	sprintf(datestr, "Date: %s", time2str(timestr, 64, time(NULL)));
> >
> > applied 1-3, and then added sizeof() to the above time2str calls...  The
> > hardcoded sizes I used for the strings is ugly enough...  let's not add
> > additional "naked numbers" on top of that.
>
> I thought wrapping was worse. Sure...

Cosmetically annoying, yes.  But hardcoding string length in multiple 
locations increases the chances of an actual bug, so...

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe hail-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html