Re: [PATCH] Move read_revisions_from_stdin from builtin-rev-list.c to revision.c

[Junio C Hamano <gitster@xxxxxxxxx>]

Miklos Vajna <vmiklos@xxxxxxxxxxxxxx> writes:

> I think it's fine to move such a function, but this is a false commit
> message, you can use read_revisions_from_stdin() from builtin-bundle if
> it lives in builtin-rev-list.c as well.

At the mechanical level, yes you _can_, but it is simply a bad taste to do
so.  More library-ish files such as revision.c are better home for utility
functions to be shared between builtins and commands.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html