Re: [PATCH v4 3/3] Add colors to interactive git-clean

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2013/5/2 Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx>:
> Jiang Xin <worldhello.net@xxxxxxxxx> writes:
>
>> Show help, error messages, and prompt in colors for interactive
>> git-clean.
>
> I find the red WARNING a bit agressive. Also, the NOTE: is the same
> color as the WARNING, hence visually similar. I first thought it was
> repeating the same message. I think it would make more sense to use
> default color, black,

Will use new style -- CLEAN_COLOR_HEADER (GIT_COLOR_BOLD)
as header for interactive git-clean (i.e.  WARNING)

> for the NOTE, by analogy with "git add -p" which
> uses it for patch hunk headers (somehow, this is the question you're
> replying to after the blue prompt below).

I agree. NOTE should only be displayed once, and will be fixed
in patch 3/1 of next reroll.

--
Jiang Xin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]