Re: [PATCH] Avoid crippled getpass function on Solaris

[Tay Ray Chuan <rctay89@xxxxxxxxx>]

On Mon, Aug 6, 2012 at 7:17 AM, Ben Walton <bwalton@xxxxxxxxxxxxxxxxxx> wrote:
> I've also briefly dabbled with getting Solaris to simply use the
> HAVE_DEV_TTY code path but the terminal echo stuff hasn't worked
> nicely for me just yet.  (It reads the password with nothing echoed
> but then displays the string after reading the newline.)  This might
> still be a better approach in the future, but for now, having long
> password reading capability will still be a benefit to users on this
> platform.

Replacing

	if (!echo) {
		putc('\n', fh);
		fflush(fh);
	}

with

	if (!echo)
		write(term_fd, "\n", 1);

fixed that. Using fd's instead of FILE* was mentioned at [1]. Perhaps
that is the direction to go in.

[1] http://mid.gmane.org/<7vsjc12j5o.fsf@xxxxxxxxxxxxxxxxxxxxxxxx>

-- 
Cheers,
Ray Chuan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html