Re: [PATCH] macos: lazily initialize iconv

[Ralf Thielow <ralf.thielow@xxxxxxxxx>]

On Tue, Jul 31, 2012 at 7:52 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> +       /* Avoid iconv_open()/iconv_close() if there is nothing to convert */
> +       for (i = 0; i < argc; i++) {
> +               if (has_utf8(argv[i], (size_t)-1, NULL))
> +                       break;
> +       }
> +       if (i < argc)
> +               return;
> +

I'm not very familiar with this code but:

before: it reencodes everything which is utf-8 in argv
after: it reencodes *nothing* if one string in argv is not in utf-8

am i wrong?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html