Re: [PATCH v2] add git credential login to remote mediawiki

[Simon Perrat <simon.perrat@xxxxxxxxx>]

2012/6/11 <Javier.Roucher-Iglesias@xxxxxxxxxxxxxxx>

> +       if ($op eq "fill") {
> +               while (<Reader>) {
> +                       my ($key, $value) = /([^=]*)=(.*)/;
> +                       # error if key undef
> +                       if (not defined $key) {
> +                               print STDERR "ERROR reciving reponse git
> credential fill\n";

rec*eiving re*sponse


> +sub ask_login {
> +       run_credential("fill");
> +
> +       if (!$mediawiki->login( {
> +               lgname => $wiki_login,
> +               lgpassword => $wiki_passwd,
> +               lgdomain => $wiki_domain,
> +               } )) {
> +                       print STDERR "Failed to log in mediawiki user
> \"$wiki_login\" on $url\n";

Is there a reason for escaping $wiki_login alone ?

> +                       print STDERR "URL:$wiki_domain $url\n";

Space after :

> +                       print STDERR "(error " .
> +                           $mediawiki->{error}->{code} . ': ' .
> +                           $mediawiki->{error}->{details} . ")\n";

Broken indentation

> +               if (!$wiki_passwd) {
> +                       #user knows, password not.
> +                       ask_login();

know*n (other instances below)
and don't forget space after # ;)


Best regards.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html