Re: [PATCH_v1] add 'git credential' plumbing command

[Junio C Hamano <gitster@xxxxxxxxx>]

Jeff King <peff@xxxxxxxx> writes:

> Perhaps it would be simpler to accept a URL on the command line, and
> also provide a --stdin option for callers that want to feed it directly.
> So:
>
>   git credential fill https://example.com/foo.git
>
> would be identical to:
>
>   git credential --stdin fill <<\EOF
>   protocol=https
>   host=example.com
>   path=foo.git
>   EOF

and "git credential fill https://peff@xxxxxxxxxxx/foo.git"; would be
identical to the latter one with user=peff already filled in?

> I am tempted to suggest that this actually output the _whole_
> credential, not just the username and password. Coupled with the above
> behavior, you would get:
>
>   $ git credential fill https://example.com/foo.git
>   protocol=https
>   host=example.com
>   path=foo.git
>   username=bob
>   password=secr3t
>
> which happens to be exactly what you want to feed back to the "approve"
> and "reject" actions (and it is not really any harder to parse).
>
> We _could_ get by with allowing:
>
>   git credential --stdin approve https://example.com/foo.git <<\EOF
>   username=bob
>   password=secr3t
>   EOF
>
> and having it combine the URL on the command-line with the entries on
> stdin (and indeed, I think that is the only sane thing to do when
> --stdin and a URL are both given).

All good suggestions ;-).


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html