Re: [PATCH] Collocate strings to simplify translation

[Johannes Sixt <j.sixt@xxxxxxxxxxxxx>]

Am 5/24/2012 11:55, schrieb Vincent van Ravesteijn:
> Op 24-5-2012 10:32, Zbigniew Jędrzejewski-Szmek schreef:
>> On 05/24/2012 09:41 AM, Vincent van Ravesteijn wrote:
>>> -    status_printf_ln(s, c, _("%s files:"), what);
>>> +    status_printf_ln(s, c, _("%s:"), what);
>> How can "%s:" be translated? _() should be removed here.
> 
> Some languages might use a character different from ':'. For example,
> Chinese uses a full-width character ':' (unicode 0xFF1A) instead of a
> half-width character. Maybe this is taken care of by the system/shell or
> whatever, maybe not. Other examples are languages that read from right to
> left. I guess it should then be translated by ":%s".
> 
> This will probably be a matter of convention.

Shouldn't you then move the colon with the "files"? That is, here we have:

-	status_printf_ln(s, c, _("%s files:"), what);
+	status_printf_ln(s, c, "%s", what);

and elsewhere we use _("Untracked files:") and _("Ignored files:").

-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html