Re: [PATCH 3/3] refs: use strings directly in find_containing_dir()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Am 23.05.2012 00:18, schrieb Junio C Hamano:
René Scharfe<rene.scharfe@xxxxxxxxxxxxxx>  writes:

What has git grep to do with refs?  It checks if the path in the command
above is a ref, which makes it iterate over all of them..

Do you mean:

	/* Is it a rev? */
         ->  ...
           ->  get_sha1_basic()
             ->  dwim_ref()


Yes, indeed. Hmm, this is done even if the paths come after a double-dash. Anyway, I don't consider the check to be a performance issue, just a quick way to test the allocation count that i stumbled upon while working on the recent grep patches.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

[Newbies FAQ]     [Linux Kernel Development]     [Free Online Dating]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Free Online Dating]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]     [Linux Resources]

Add to Google