Re: [PATCH 2/4] notes: "add -c" refuses to open an editor with non-blobs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Thu, May 10, 2012 at 10:26 PM, Johannes Sixt <j.sixt@xxxxxxxxxxxxx> wrote:
> Am 5/10/2012 16:04, schrieb Nguyễn Thái Ngọc Duy:
>> +test_expect_success 'non-blobs cannot be edited using editor' '
>> +     EDITOR=cat test_must_fail git notes add -f -c HEAD^{tree}
>        (
>                test_set_editor cat &&
>                test_must_fail git notes add -f -c HEAD^{tree}
>        )
> Ditto in 3/4 and 4/4.
> (The problem is not that test_set_editor must be used, but that VAR=value
> in front of a shell function invocation does not do what you want it to do
> unless your shell is buggy.)

thanks. I looked again and t3301 already exports GIT_EDITOR, so we can
skip setting EDITOR again.

>> +'
> -- Hannes

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

[Newbies FAQ]     [Linux Kernel Development]     [Free Online Dating]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Free Online Dating]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]     [Linux Resources]

Add to Google