Re: [PATCH 10/19] completion: use bash builtins to search for repository

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

SZEDER Gábor <szeder@xxxxxxxxxx> writes:

> I'm not sure what you mean by opt-in.  It's already opt-in in the
> sense that users have to set $GIT_DISCOVERY_ACROSS_FILESYSTEM to
> enable this logic.  Or do you mean that
> $GIT_DISCOVERY_ACROSS_FILESYSTEM should not implicitly enable this
> logic, but it should be controlled by a new dedicated variable?

Exactly.  In the three words in DISCOVERY_ACROSS_FILESYSTEM, I do not see
anything that indicates that the user wishes to use a "may be faster in
some situations but may be less correct" behaviour for one thing.  Also,
some day you or somebody else may find out how to take advantage of the
new code in this patch series and still stop at the filesystem boundary
and at that point, people may want to still forbid git to go up across
filesystem boundary and want to use the new prompt code.  Tying these two
independent concepts (i.e. "do I want to use the new experimental prompt
code?" and "do I want git to stop going up across fs boundaries?")
together only because the initial implementation happens to rely on it is
not such a good idea.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

[Newbies FAQ]     [Linux Kernel Development]     [Free Online Dating]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Free Online Dating]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]     [Linux Resources]

Add to Google