Re: [PATCH/RFC] clone: inform the user we are checking out

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 7, 2012 at 11:26 AM, Johannes Sixt <j.sixt@xxxxxxxxxxxxx> wrote:
> Am 5/7/2012 11:09, schrieb Erik Faye-Lund:
>> When cloning a large repository over a local file-system
> ...
>> $ git clone some-repo.git some-other-repo
>> Cloning into 'some-other-repo'...    <happens instantly>
>> done.                                <hangs for minutes>
>> $
> ...
>> I asked git
>> to clone, and it told me it finished, only to hang around for
>> several minutes while, judging by the output, doing nothing.
>
> We have a nice "Checking out files" progress indicator. I wonder why you
> do not see it.
>

That's a very good point, I forgot about that one. I'll investigate
that part. Just to be clear, I'm seeing this problem on version
1.7.10.1.457.g8275905 (junio's 'master' as of right now, AFAICT) on
CentOS. I've built with:
NO_OPENSSL = YesPlease
NO_CURL = YesPlease

"git config -l" does not reveal that any progress related
config-options are set.

> At any rate, it's better to write "done" only after we're really done.

Well, perhaps, but at the same time perhaps not: We only write it for
local clones, because the remote-clones are quite chatty to begin
with, and the remote-stuff seems to inform about it's actions by
printing "<performing task x>...done!". Moving the final
"done."-printing to the very end might be a step in making these
outputs even less consistent. But it might not be important.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]