Re: [PATCH v5 1/5] http: try http_proxy env var when http.proxy config option is not set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Jeff King <peff@xxxxxxxx> writes:

> On Fri, Apr 13, 2012 at 04:48:58PM -0400, Jeff King wrote:
>
>> > +	if (!curl_http_proxy) {
>> > +		const char *env_proxy, *no_proxy;
>> > +		char *env_proxy_var;
>> > +		int read_http_proxy;
>> > +		struct strbuf buf = STRBUF_INIT;
>> > +		credential_from_url(&cre_url, url);
>> > +		strbuf_addf(&buf, "%s_proxy", cre_url.protocol);
>> > +		env_proxy_var = strbuf_detach(&buf, NULL);
>> > +		env_proxy = getenv(env_proxy_var);
>
> Also, shouldn't we be checking HTTPS_PROXY in addition to https_proxy,
> by curl's rules? Only http_proxy is not allowed to be upper-cased.

Good point.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Newbies FAQ]     [Linux Kernel Development]     [Free Online Dating]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Free Online Dating]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]     [Linux Resources]

Add to Google