Re: [PATCH] Explain how svn-fe parses filenames in SVN dumps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 14/04/12 18:14, Jonathan Nieder wrote:
> this description and the location of this description seem quite
> misleading.  Isn't what the reader needs to know something like the
> following?
> 
> 	BUGS
> 	----
> 	Due to limitations in the Subversion dumpfile format, svn-fe
> 	does not support filenames with newlines.  Since version 1.2.0,
> 	"svn add" forbids adding such filenames but some historical
> 	repositories contain them.  An import can appear to succeed and
> 	produce incorrect results when such pathological filenames are
> 	present.
> 
> Thanks,
> Jonathan
> 

I went back and forth a bit while writing the text.  Newlines are only
one special case, albeit an important one that I hadn't expressed
clearly enough.  For example, the handling of NUL characters is worse
than newlines (a quick test suggests svn-fe terminates parsing
altogether if it sees one), but SVN has never allowed the creation of
files with NULs so arguably it's even less important.

I'm warming again to the idea of explicitly mentioning that newlines
cause breakage, but it feels like the wider story is worth telling too.
 If this were a man page I'd consider adding a section or something, but
I'm not sure what level of verbosity you're looking for in this file.

	- Andrew
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Newbies FAQ]     [Linux Kernel Development]     [Free Online Dating]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Free Online Dating]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]     [Linux Resources]

Add to Google