Re: push.default: current vs upstream

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Thu, Apr 12, 2012 at 10:09:35AM +0200, Matthieu Moy wrote:

> Jeff King <peff@xxxxxxxx> writes:
> 
> > I think it is as simple as applying the usual upstream rules, then
> > checking the remote name against the local name. Like this:
> 
> This fails if no upstream is configured. I think applying "current"
> instead of failing in this case makes perfect sense (i.e. "simple"
> should fail only if there is an upstream configured, and it has a
> different name).

Then the rule is not really "act only if upstream and current would do
the same thing".

On the one hand, I think what you are suggesting is reasonable in most
cases. On the other hand, what if the lack of upstream is because the
user failed to configure it properly? Then it could be surprising.

I don't have a strong opinion either way. Do you want to pick up my
patch and start tweaking?

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Newbies FAQ]     [Linux Kernel Development]     [Free Online Dating]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Free Online Dating]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]     [Linux Resources]

Add to Google