Re: [PATCH 00/15] Hierarchical reference cache (once again)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Tue, Apr 10, 2012 at 07:30:12AM +0200, mhagger@xxxxxxxxxxxx wrote:

> Michael Haggerty (15):
>   refs.c: reorder definitions more logically
>   refs: manage current_ref within do_one_ref()
>   do_for_each_ref_in_array(): new function
>   do_for_each_ref_in_arrays(): new function
>   repack_without_ref(): reimplement using do_for_each_ref_in_array()
>   names_conflict(): new function, extracted from is_refname_available()
>   names_conflict(): simplify implementation
>   is_refname_available(): reimplement using do_for_each_ref_in_array()
>   free_ref_entry(): new function
>   check_refname_component(): return 0 for zero-length components
>   struct ref_entry: nest the value part in a union
>   refs.c: rename ref_array -> ref_dir
>   sort_ref_dir(): simplify logic
>   refs: store references hierarchically
>   do_for_each_ref(): only iterate over the subtree that was requested

I read through the whole series and didn't find anything noticeably
wrong.  Overall, it was quite readable for such a large series. Thanks
for breaking it up as you did.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Newbies FAQ]     [Linux Kernel Development]     [Free Online Dating]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Free Online Dating]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]     [Linux Resources]

Add to Google