Re: [PATCH 1/5] t1507: add additional tests for @{upstream}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 04/11/2012 07:59 PM, Matthieu Moy wrote:
Junio C Hamano<gitster@xxxxxxxxx>  writes:

We may want to update the error message for "@{u}" when the current one is
not tracked, instead of saying ''.  Perhaps

	error: No upstream branch found for the current branch.

or something?

Likewise for the detached HEAD case.

This is indeed the point of the patch serie, and I like how it first
shows how bad the error messages can be, and then illustrate the fix
with patch hunks in the newly added testcases in further patches.

But the commit message for this patch could probably be improved: we
usually do not give a list of _what_ is done, since the code already
says that, but we insist on _why_ it is done.
Yeah, I need to provide a better motivation/description in reroll.

Thanks for looking at this,
Zbyszek
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Newbies FAQ]     [Linux Kernel Development]     [Free Online Dating]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Free Online Dating]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]     [Linux Resources]

Add to Google