Re: [PATCH 1/5] t1507: add additional tests for @{upstream}

[Junio C Hamano <gitster@xxxxxxxxx>]

Junio C Hamano <gitster@xxxxxxxxx> writes:

> Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> writes:
>
>> +error_message () {
>> +	(cd clone &&
>> +	 test_must_fail git rev-parse --verify "$@")
>> +}
>> ...
>> +test_expect_success 'branch@{u} error message when no upstream' '
>> +	cat >expect <<-EOF &&
>> +	error: No upstream branch found for ${sq}non-tracking${sq}
>> +	fatal: Needed a single revision
>> +	EOF
>> +	(cd clone &&
>> +	 test_must_fail git rev-parse --verify non-tracking@{u}) 2>actual &&
>
> Why not use "error_message" as other new tests?

I think the remainder of the message should be ignored.  Will comment on
individual steps.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html