Re: sha-1 check in rev-list --verify-objects redundant?
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> writes: > On Sun, Feb 26, 2012 at 06:11:30PM +0700, Nguyen Thai Ngoc Duy wrote: >> "rev-list --objects" does check for blob existence, in finish_object(). > > Eck.. I think "--quiet --verify-objects" becomes "--quiet --objects" > because of this code: > > -- 8< -- > traverse_commit_list(&revs, > quiet ? finish_commit : show_commit, > quiet ? finish_object : show_object, > &info); > -- 8< -- > > Unless that's intentional, shouldn't we apply this patch? --quiet's > interfering with rev-list's business sounds weird to me. Good thinking. Anything we are missing by calling finish_* other than printing is a similar bug waiting to happen. Can't we push the quiet bit in the info structure and have a single pair of callback functions, so that we can make sure this kind of glitch would never happen? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
[Newbies FAQ] [Linux Kernel Development] [Free Online Dating] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Free Online Dating] [Photo] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users] [Linux Resources]