[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [ogfs-dev]Map OpenDLM to G-lock: lock name

> -----Original Message-----
> From: Stanley Wang [mailto:stanley.wang@linux.co.intel.com]
> Sent: Thursday, August 14, 2003 3:22 AM
> To: opengfs-devel@lists.sourceforge.net
> Subject: RE: [ogfs-dev]Map OpenDLM to G-lock: lock name

> Because the locktable is unique for ogfs instant (L78 in
> locking/module/memexp/moduleops.c), I prefer to use the last four
> characters as the identity. Hence we need some more space.
> #define OGFS_DLM_MAGIC		"OGFS"
> stuct lock_name {
> 	unsigned char		magic[4];
> 	unsigned char		lock_table[OGFS_DLM_LOCKTABLE];
> 	unsigned long long	lock_number;
> 	unsigned char		lock_type; /* expand to 32 bit? */
> } __attribute__ ((packed));
> Does it look better?

Good.  (and thanks to Peter B for his comments on "OGFS").  One last thought regarding computational efficiency within OpenDLM:  Would it be better to have the *unique* elements (lock_number and lock_type) at the beginning of the name, to keep comparison searches as short as possible?

-- Ben --

Opinions are mine, not Intel's

This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
Opengfs-devel mailing list

[Kernel]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Clusters]     [Linux RAID]     [Yosemite Hiking]     [Linux Resources]

Powered by Linux