Re: [PATCH] Fix segfault with verify_async

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 2011-10-25 22:23, Steven Lang wrote:
> At some point the filename was added to the report on verify failures,
> however this broke verify_async, as the file pointer on the io_u is
> set to NULL before the verify thread sees the io_u.  The result is a
> segfault when there is a verify mismatch.
> 
> This patch changes the semantics of a deferred free (IO_U_F_FREE_DEF)
> to have already called put_file, but not set the file pointer to NULL.
>  This is safe to do as the file list is only freed after all the
> verify threads have been terminated.

Thanks Steven, good catch. Applied.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Home]     [Linux SCSI]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Video Projectors]     [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Powered by Linux