Re: [PATCH 1/2] Added replay_rebase option to run multi-threaded log replay on different disk sectors.
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On 2011-09-15 08:23, Taisuke Yamada wrote: >>> [snip], I added "replay_rebase" option to shift offset of IO request for >>> each thread. >> >> Thanks, I can see this being handy. I can apply this, but I would much >> prefer if you resend it with the proper updates to HOWTO and fio.1 >> adding the new option. Otherwise nobody is going to learn about it. > > Just in case you have missed (I had to break In-Reply-To chain as git > format-patch did not respect it). I'm re-posting updated patch with docs. > Please apply #1 and #2 if it seems acceptable. On patch 1, I don't know, it seems a bit weird to me. The fact that the option offset is multiplied by the job number makes sense for ease of handling job files (since you can just do numjobs=X and be done with it), but logically it's odd since you have to know that they are numbered sequentially and do the math to see where it ends up on the disk. What is the intended use case for this? I'd much rather see the offset be absolute, at the cost of a bit more complex job file. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html