Re: [PATCH 1/2] Added replay_rebase option to run multi-threaded log replay on different disk sectors.

[Jens Axboe <axboe@xxxxxxxxx>]

On 2011-09-15 08:23, Taisuke Yamada wrote:
>>> [snip], I added "replay_rebase" option to shift offset of IO request for
>>> each thread.
>>
>> Thanks, I can see this being handy. I can apply this, but I would much
>> prefer if you resend it with the proper updates to HOWTO and fio.1
>> adding the new option. Otherwise nobody is going to learn about it.
> 
> Just in case you have missed (I had to break In-Reply-To chain as git
> format-patch did not respect it). I'm re-posting updated patch with docs.
> Please apply #1 and #2 if it seems acceptable.
> 
> I believe #2 patch is also worth adding to fio, but not sure if I should make
> it optional feature (/w doc) or not. By wraparounding offset address, it'll
> probably make benchmark result look better than actual for rotational disk
> drives. OTOH, it's better than failing to run just because trace-generating
> device was larger than replaying device.

I worry about the 2nd patch, it's a bit of a hack. You could make it an
option and turn it on unconditionally for replay_rebase, or at least
make it conditional on that.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html