Re: fio: when not using a job file, timeouts are not applied

[Jens Axboe <jaxboe@xxxxxxxxxxxx>]

On 2011-07-19 02:21, Daniel Farina wrote:
> On Mon, Jul 18, 2011 at 5:19 PM, Chris Worley <worleys@xxxxxxxxx> wrote:
>> Do you mean to be using --timeout or --runtime?
> 
> --timeout.  It's pretty clear the semantics using a job file and those
> without a job file are not the same, or are you not able to reproduce
> this?

Sorry for the late reply, I'm on vacation. This should fix it.

diff --git a/init.c b/init.c
index 85bd0f7..98e10f7 100644
--- a/init.c
+++ b/init.c
@@ -47,7 +47,6 @@ int warnings_fatal = 0;
 int write_bw_log = 0;
 int read_only = 0;
 
-static int def_timeout;
 static int write_lat_log;
 
 static int prev_group_jobs;
@@ -951,8 +950,6 @@ static int fill_def_thread(void)
 	 * fill default options
 	 */
 	fio_fill_default_options(&def_thread);
-
-	def_thread.o.timeout = def_timeout;
 	return 0;
 }
 
@@ -1160,7 +1157,7 @@ static int parse_cmd_line(int argc, char *argv[])
 			smalloc_pool_size = atoi(optarg);
 			break;
 		case 't':
-			def_timeout = atoi(optarg);
+			def_thread.o.timeout = atoi(optarg);
 			break;
 		case 'l':
 			write_lat_log = 1;

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html