Re: Systemd scriptlet comments

[Ville Skyttä <ville.skytta@xxxxxx>]

On 06/03/2011 11:02 PM, Ville Skyttä wrote:
> Some comments on systemd scriptlets at
> http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd

Ping?  I think at least 1) below is important enough to be addressed
before wider systemd conversion starts to take place.

> 1) I don't think the versioned trigger logic will work too well at all
> in the (not that rare) cases where the previous distro had sysv scripts
> and one does a version bump in the previous distro - the trigger in the
> next one will no longer run on distro upgrades because of the
> versioning.  Wouldn't it work better to just drop the version from the
> trigger altogether, and instead check if the old init script exists?
> For example:
> 
> %triggerun -- httpd
> [ -e %{_initddir}/httpd ] || exit 0
> # rest of the migration stuff goes here
> 
> 2) Cosmetic: there are unnecessary '|| :'s sprinkled in the scriptlets,
> only the final exit status of a script has any effect.
> 
> 3) More or less cosmetic: why hardwire absolute paths everywhere?  The
> vast majority of other scriptlet snippets don't do that.
--
packaging mailing list
packaging@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/packaging