[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service

[bugzilla@xxxxxxxxxx]

https://bugzilla.redhat.com/show_bug.cgi?id=845107

--- Comment #13 from Adam Miller <admiller@xxxxxxxxxx> ---
SPEC URL:
http://maxamillion.fedorapeople.org/rubygem-openshift-origin-msg-broker-mcollective.spec
SRPM URL:
http://maxamillion.fedorapeople.org/rubygem-openshift-origin-msg-broker-mcollective-0.1.1-4.fc17.src.rpm

- Removed unneeded ruby_sitelib

- moved license and readme to original location

- removed policycoreutils-python and selinux-policy-targeted as deps
    After speaking with the upstream author, it was agreed upon that these were
not hard requirements.

- changed stickshift-common dep to openshift-origin-common for F18 pkg naming
    This was a complete oversight on my part, apologies

- added doc subpackage
    Was looking at the package manifest and the docs were overpowering so I
moved them.


On the topic of a test suite, there currently are not any unit tests listed
under the rake task. I spoke with upstream and this is still being planned,
currently the testing is done using cucumber in the upstream CI environment and
requires a running system/environment to test against so it wouldn't be
applicable to the package currently.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review